feat(attachments): Redirect Objectstore-backed attachment downloads to Objectstore - #120958
Draft
jan-auer wants to merge 1 commit into
Draft
feat(attachments): Redirect Objectstore-backed attachment downloads to Objectstore#120958jan-auer wants to merge 1 commit into
jan-auer wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
This was referenced Jul 31, 2026
jan-auer
marked this pull request as draft
July 31, 2026 10:40
Member
Author
|
Waiting with the rollout until Produces have been updated for at least a week to cover most attachments: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attachment downloads (
GET .../attachments/<id>/?download=1) now return a 302 for attachments stored in Objectstore, so the payload no longer travels through Sentry. Internal callers are redirected straight to Objectstore; external callers go through the locality's Objectstore proxy, which continues to negotiateAccept-Encodingand decompress for clients that don't accept zstd. Inline and legacy filestore (eventattachments/v1/) attachments are unchanged and still stream.This applies to every Objectstore-backed attachment with no feature flag, reusing the
get_download_redirect_urlhelper thatProjectDebugFilealready uses.Known regression: Objectstore only sends
Content-Dispositionwhen the object was stored withfilenamemetadata, and none of the attachment write paths (EventAttachment.putfile, Relay,reprocessing2) set it today. Downloads will therefore be named after the storage key instead of the attachment name. Fixing it requires the write paths to pass a sanitized filename — attachment names are SDK-controlled and cannot go into an HTTP header unescaped — and would only help newly stored objects, so it is left as follow-up.Refs FS-466